【Hackathon】64. huber_loss 算子 fp16/bf16 完善 #53535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
|
❌ The PR is not created using PR's template. You can refer to this Demo. |
ZzSean
reviewed
May 10, 2023
| @@ -25,7 +26,10 @@ struct HuberLossForward { | |||
| HOSTDEVICE HuberLossForward(const T& delta) : delta(delta) {} | |||
|
|
|||
| HOSTDEVICE T operator()(const T& val) const { | |||
| T abs_val = std::abs(val); | |||
| using MPType = typename phi::dtype::MPTypeTrait<T>::Type; | |||
There was a problem hiding this comment.
std::abs 没有float16类型参数，需要增加MPType转换
如果val, delta都使用MPType计算，delta也需要转换，这样减少delta的转换
以后可以对std::abs封装float16，替换这里代码
ZzSean
reviewed
May 10, 2023
| T abs_val = std::abs(val); | ||
| using MPType = typename phi::dtype::MPTypeTrait<T>::Type; | ||
| MPType mt_val = static_cast<MPType>(val); | ||
| MPType mt_abs_val = std::abs(mt_val); |
There was a problem hiding this comment.
可以直接使用abs，Paddle中对这两种数据类型的abs计算应该都做了重载
ZzSean
reviewed
May 11, 2023
paddle/phi/common/bfloat16.h
Outdated
| @@ -401,4 +401,8 @@ struct numeric_limits<phi::dtype::bfloat16> { | |||
| } | |||
| }; | |||
|
|
|||
| HOSTDEVICE inline phi::dtype::bfloat16 abs(const phi::dtype::bfloat16& a) { | |||
| return phi::dtype::abs(a); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
huber_loss 算子 fp16/bf16 完善