Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

delete useless cast, elementwise_mul #52831

Merged
merged 2 commits into from
Apr 13, 2023
Merged

delete useless cast, elementwise_mul #52831

merged 2 commits into from
Apr 13, 2023

Conversation

zhupengyang
Copy link
Contributor

@zhupengyang zhupengyang commented Apr 12, 2023 •
edited
Loading

PR types

Performance optimization

PR changes

Others

Describe

  • scatter 可以支持 fp16，删除前后的 cast
  • 删除其中一个输入全为为 1 的 elementwise_mul

@paddle-bot
Copy link

paddle-bot bot commented Apr 12, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

hong19860320
hong19860320 approved these changes Apr 13, 2023
View reviewed changes
Copy link
Contributor

@hong19860320 hong19860320 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhupengyang zhupengyang merged commit 0695fb8 into PaddlePaddle:develop Apr 13, 2023
@zhupengyang zhupengyang deleted the xpu_remove_small_ops branch April 13, 2023 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hong19860320 hong19860320 hong19860320 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhupengyang @hong19860320