-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a new python script topology.py and its corresponding unittest fo… #52723
Conversation
你的PR提交成功,感谢你对开源项目的贡献! |
changtao02 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
…r single-node topology detection
f59397a
to
7502093
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
||
for i in range(len(link_types)): | ||
link = {} | ||
link['source_global_id'] = link_source_global_ids[i] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the global_id
actually the local_id
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in single-node case, yep
PR types
New features
PR changes
Others
Describe
This PR add a new python script topology.py and its corresponding unittest for single-node topology detection