[PHI]Unify fluid kernel (Part4) #52626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
huangjiyi
reviewed
Apr 17, 2023
Comment on lines
99
to
103
| set(run_program_op_srcs run_program_op.cc) | ||
| if (WITH_GPU OR WITH_ROCM) | ||
| list(APPEND run_program_op_srcs run_program_op.cu) | ||
| endif() | ||
| op_library(run_program_op SRCS ${run_program_op_srcs} DEPS executor_cache ${OP_HEADER_DEPS}) |
There was a problem hiding this comment.
这里可以直接用 op_library(run_program_op DEPS executor_cache ${OP_HEADER_DEPS}) 吗，在 op_library 的逻辑里会自动搜索和 op 同名的 src 文件，并自动使用相应的宏处理
zyfncg
approved these changes
Apr 17, 2023
wanghuancoder
approved these changes
Apr 17, 2023
jjyaoao
pushed a commit
to jjyaoao/Paddle
that referenced
this pull request
Apr 19, 2023
* unify kernel * fix ci bugs * fix py3 bugs * fix py3 bugs * perfect code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
Pcard-67000
将以下Fluid op注册到phi中：
recv_v2
resnet_unit
retinanet_detection_output
roi_perspective_transform
row_conv
rpn_target_assign
run_program