[enforce.h Decouple gflags.h] Move gflags.h from enforce.h to enforce.cc #52573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
jiahy0825
force-pushed
the
enforce-decouple-gflags
branch
from
64cca74
to
7ad1ead
Compare
jiahy0825
force-pushed
the
enforce-decouple-gflags
branch
from
7ad1ead
to
1bf426d
Compare
zyfncg
approved these changes
Apr 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Function optimization
PR changes
Others
Describe
Pcard-66989
Background
After exposing the header files of phi, error will occur when users include header files which depend on "gflags.h" and "glog/logging.h", so that we need to decouple such dependence of header files.
Changes
This PR moves "gflags.h" from enforce.h to enforce.cc.