[AMP OP&Test] add fp16/bf16 unittest for pool2d op #52288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
|
❌ The PR is not created using PR's template. You can refer to this Demo. |
weisy11
changed the title
ZzSean
reviewed
Apr 3, 2023
| @@ -14,7 +14,10 @@ | |||
|
|
|||
| #include "paddle/phi/kernels/pool_grad_kernel.h" | |||
|
|
|||
| #include "paddle/phi/common/bfloat16.h" | |||
| #include "paddle/phi/common/data_type.h" | |||
| ) | ||
|
|
||
| if self.is_bfloat16_op(): | ||
| output = output.astype(np.float32) |
There was a problem hiding this comment.
output也需要调用convert_float_to_uint16
| place = core.CUDAPlace(0) | ||
| self.check_output_with_place( | ||
| place, | ||
| atol=1e-3, |
| place, | ||
| {'X'}, | ||
| 'Out', | ||
| max_relative_error=0.07, |
There was a problem hiding this comment.
max_relative_error需要先尝试默认值，其他的fp16单测也需要先尝试默认值
| @@ -847,6 +912,20 @@ def init_shape(self): | |||
| create_test_cudnn_fp16_class(TestCase4_channel_last) | |||
| create_test_cudnn_fp16_class(TestCase5_channel_last) | |||
|
|
|||
| create_test_fp16_class(TestPool2D_channel_last) | |||
| create_test_fp16_class(TestCase1_channel_last, check_grad=False) | |||
There was a problem hiding this comment.
check_grad是否必需？之前设置为true可能是因为单测框架有问题，现在可以试着去掉测下
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
OPs
Describe
add bf16 support and bf16/fp16 unittest for pool2d