[AMP OP&Test] Arg min max bf16 test #52276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… arg_min_max_test
|
你的PR提交成功，感谢你对开源项目的贡献! |
Vvsmile
reviewed
Mar 29, 2023
Vvsmile
reviewed
Mar 29, 2023
| @unittest.skipIf( | ||
| not paddle.is_compiled_with_cuda(), "BFP16 test runs only on GPU" | ||
| ) | ||
| class BFP16TestCase0(OpTest): |
There was a problem hiding this comment.
单测类内部没有添加test_check_output和test_check_grad，这会导致此单测类没有真正执行测试代码
Vvsmile
reviewed
Mar 29, 2023
| self.dims = (3, 4, 5) | ||
| self.axis = 0 | ||
|
|
||
| def SetUp(self): |
There was a problem hiding this comment.
BF16的单测的setUp中最好设置上self.dtype = np.uint16
Vvsmile
reviewed
Mar 29, 2023
| self.inputs = {'X': self.x} | ||
| self.attrs = {'axis': self.axis} | ||
| if self.op_type == "arg_min": | ||
| self.outputs = {'Out': np.argmin(x, axis=self.axis)} |
There was a problem hiding this comment.
self.outputs 字典中的值部分请调用convert_float_to_uint16进行转换
There was a problem hiding this comment.
argmin 返回的已然是 int
Vvsmile
reviewed
Mar 29, 2023
Vvsmile
reviewed
Mar 29, 2023
| @unittest.skipIf( | ||
| not paddle.is_compiled_with_cuda(), "BFP16 test runs only on GPU" | ||
| ) | ||
| class BFP16TestCase0(OpTest): |
There was a problem hiding this comment.
类名按照规范从BFP16TestCase1修改为TestArgMinBF16OP
|
确定一下API Check Dtype任务是否完成 |
… arg_min_max_test
|
done |
wanghuancoder
approved these changes
Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Performance optimization
PR changes
OPs
Describe
Arg min max bf16 test