Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add autogen code support for sigmoid_cross_entropy_with_logits #52263

Conversation

gouzil
Copy link
Member

@gouzil gouzil commented Mar 28, 2023

PR types

Others

PR changes

Others

Describe

add autogen code support for sigmoid_cross_entropy_with_logits

有一个问题是sigmoid_cross_entropy_with_logits这个算子有 mlu 和 npu 的实现,是否需要删除

paddle/fluid/operators/sigmoid_cross_entropy_with_logits_op_mlu.cc
paddle/fluid/operators/sigmoid_cross_entropy_with_logits_op_npu.cc

相关issues

@paddle-bot
Copy link

paddle-bot bot commented Mar 28, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Mar 28, 2023
@heavyrain-lzy
Copy link
Contributor

PR types

Others

PR changes

Others

Describe

add autogen code support for sigmoid_cross_entropy_with_logits

有一个问题是sigmoid_cross_entropy_with_logits这个算子有 mlu 和 npu 的实现,是否需要删除

paddle/fluid/operators/sigmoid_cross_entropy_with_logits_op_mlu.cc
paddle/fluid/operators/sigmoid_cross_entropy_with_logits_op_npu.cc

相关issues

mlu和npu相关文件不做处理,后续会有其他相关开发人员清理。

Copy link
Contributor

@heavyrain-lzy heavyrain-lzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit 710c13e into PaddlePaddle:develop Mar 30, 2023
@gouzil gouzil deleted the autogen_code_sigmoid_cross_entropy_with_logits branch May 15, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants