Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMP OP&Test]Add fp16/bf16 support isnan/isfinite/isinf op #52259

Merged
merged 17 commits into from
Apr 11, 2023

Conversation

wjj19950828
Copy link
Contributor

@wjj19950828 wjj19950828 commented Mar 28, 2023

PR types

Performance optimization

PR changes

OPs

Describe

  • Add fp16/bf16 support isnan/isfinite/isinf op

@paddle-bot
Copy link

paddle-bot bot commented Mar 28, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot
Copy link

paddle-bot bot commented Mar 28, 2023

❌ The PR is not created using PR's template. You can refer to this Demo.
Please use PR's template, it helps save our maintainers' time so that more developers get helped.

@wjj19950828 wjj19950828 requested a review from ZzSean March 28, 2023 14:41
@@ -16,6 +16,7 @@

import numpy as np
from eager_op_test import OpTest
from op_test import convert_float_to_uint16
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eager_op_test中import

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

self.outputs = {'Out': out}

def test_output(self):
self.check_output()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里需要直接调用check_output_with_place,不然CPU的place会报错

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@@ -48,6 +48,26 @@ def init_dtype(self):
self.dtype = np.float16


# BFP16 isinf Test
@unittest.skipIf(
not core.is_compiled_with_cuda(), "core is not compiled with CUDA"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里也需要加一下gpu是否支持bf16的判断

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@wjj19950828 wjj19950828 reopened this Apr 11, 2023
Copy link
Contributor

@ZzSean ZzSean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZzSean ZzSean merged commit aaf873b into PaddlePaddle:develop Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants