Add Gloo SendRecv Function #52221
Merged
Add Gloo SendRecv Function #52221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
kuizhiqing
reviewed
Mar 29, 2023
| tensor_y = paddle.to_tensor(y) | ||
|
|
||
| send_recv_result = paddle.assign(tensor_x) | ||
| if rank == 0: |
There was a problem hiding this comment.
- Use
pg.rankwould be better - add send from 1 to 0
kuizhiqing
reviewed
Mar 29, 2023
Comment on lines
+115
to
+125
| if pg.rank() == 0: | ||
| task = pg.send(tensor_x, 1, True) | ||
| else: | ||
| task = pg.recv(tensor_y_1, 0, True) | ||
| assert np.array_equal(send_recv_result_1, tensor_y_1) | ||
|
|
||
| if pg.rank() == 0: | ||
| task = pg.recv(tensor_x, 1, True) | ||
| assert np.array_equal(send_recv_result_2, tensor_x) | ||
| else: | ||
| task = pg.send(tensor_y_2, 0, True) |
sneaxiy
reviewed
Mar 29, 2023
| const auto slot = gloo::Slot::build(kSendRecvSlotPrefix, opts->tag); | ||
|
|
||
| if (context->rank == opts->src) { | ||
| in->send((context->rank + 1) % 2, slot); |
There was a problem hiding this comment.
Why (context->rank + 1) % 2? Same below.
Does gloo support P2P communication even if the world size of the process group is larger than 2?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
OPs
Describe
Add Gloo SendRecv Function