Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【Hackathon No.55】add fmax BF16 test #51925

Merged
merged 12 commits into from
Apr 27, 2023
Merged
Show file tree
Hide file tree
Changes from 9 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions paddle/phi/kernels/funcs/elementwise_functor.h
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,17 @@ struct FMaxFunctor<dtype::float16> {
}
};

template <>
struct FMaxFunctor<dtype::bfloat16> {
inline HOSTDEVICE dtype::bfloat16 operator()(const dtype::bfloat16 a,
const dtype::bfloat16 b) const {
float float_a = static_cast<float>(a);
float float_b = static_cast<float>(b);
auto result = std::fmax(float_a, float_b);
return static_cast<dtype::bfloat16>(result);
}
};

template <>
struct FMaxFunctor<int> {
inline HOSTDEVICE int operator()(const int a, const int b) const {
Expand Down Expand Up @@ -265,6 +276,16 @@ struct FMaxGradDx<dtype::float16> {
}
};

template <>
struct FMaxGradDx<dtype::bfloat16> {
HOSTDEVICE dtype::bfloat16 operator()(dtype::bfloat16 x,
dtype::bfloat16 y,
dtype::bfloat16 out,
dtype::bfloat16 dout) const {
return dout * static_cast<dtype::bfloat16>((x >= y) || dtype::isnan(y));
superwinner1 marked this conversation as resolved.
Show resolved Hide resolved
}
};

template <>
struct FMaxGradDx<int> {
HOSTDEVICE int operator()(int x, int y, int out, int dout) const {
Expand Down Expand Up @@ -299,6 +320,16 @@ struct FMaxGradDy<dtype::float16> {
}
};

template <>
struct FMaxGradDy<dtype::bfloat16> {
HOSTDEVICE dtype::bfloat16 operator()(dtype::bfloat16 x,
dtype::bfloat16 y,
dtype::bfloat16 out,
dtype::bfloat16 dout) const {
return dout * static_cast<dtype::bfloat16>(!((x >= y) || dtype::isnan(y)));
superwinner1 marked this conversation as resolved.
Show resolved Hide resolved
}
};

template <>
struct FMaxGradDy<int64_t> {
HOSTDEVICE int64_t operator()(int64_t x,
Expand Down
1 change: 1 addition & 0 deletions paddle/phi/kernels/gpu/elementwise_grad_kernel.cu
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,7 @@ PD_REGISTER_KERNEL(fmax_grad,
double,
int,
phi::dtype::float16,
phi::dtype::bfloat16,
int64_t) {}

PD_REGISTER_KERNEL(fmin_grad,
Expand Down
1 change: 1 addition & 0 deletions paddle/phi/kernels/kps/elementwise_kernel.cu
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,7 @@ PD_REGISTER_KERNEL(fmax,
double,
int,
float16,
bfloat16,
int64_t) {}

PD_REGISTER_KERNEL(fmin,
Expand Down
28 changes: 27 additions & 1 deletion python/paddle/fluid/tests/unittests/test_fmax_op.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
import unittest

import numpy as np
from eager_op_test import OpTest
from eager_op_test import OpTest, convert_float_to_uint16

import paddle
import paddle.fluid.core as core
Expand Down Expand Up @@ -241,5 +241,31 @@ def test_check_grad_normal(self):
self.check_grad(['X', 'Y'], 'Out')


@unittest.skipIf(
not core.is_compiled_with_cuda()
or not core.is_bfloat16_supported(core.CUDAPlace(0)),
"core is not compiled with CUDA and not support the bfloat16",
)
class TestFmaxBF16OP(OpTest):
def setUp(self):
self.op_type = "elementwise_fmax"
self.python_api = paddle.fmax
self.dtype = np.uint16
x = np.random.randn(11, 17).astype('float32')
y = np.random.randn(11, 17).astype('float32')
out = np.fmax(x, y)
self.inputs = {
'X': convert_float_to_uint16(x),
'Y': convert_float_to_uint16(y),
}
self.outputs = {'Out': convert_float_to_uint16(out)}

def test_check_output(self):
self.check_output()

def test_check_grad(self):
self.check_grad(['X', 'Y'], 'Out')


if __name__ == "__main__":
unittest.main()