support auto generate for prelu #51913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ainavo
changed the title
Closed
|
rerun一下相关CI，关注一下 |
| @@ -1089,6 +1089,16 @@ | |||
| data_type : x | |||
| backward : pow_grad | |||
|
|
|||
| - op : prelu | |||
There was a problem hiding this comment.
查看ci-coverage, 这个错误可能是由test_dropout_nd_op.py引入的，目前已经屏蔽了这个单测，可以再rerun一下相关CI
paddle/phi/api/yaml/backward.yaml
Outdated
| args : (Tensor x, Tensor alpha, Tensor out_grad, str data_format, str mode) | ||
| output : Tensor(x_grad), Tensor(alpha_grad) | ||
| infer_meta : | ||
| func : GeneralBinaryGradInferMeta |
There was a problem hiding this comment.
mkldnn失败的原因已确定，这里的不能直接使用GeneralBinaryGradInferMeta,需要新增函数。建议如下：
- 这里修改为
PreluGradInferMeta - 在
paddle/phi/infermeta/backward.cc文件的PixelUnshuffleGradInferMeta函数后面增加函数
void PreluGradInferMeta(const MetaTensor& x,
const MetaTensor& y,
MetaTensor* dx,
MetaTensor* dy) {
if (dx) {
dx->share_dims(x);
}
if (dy) {
dy->share_dims(y);
}
}
- 在头文件
paddle/phi/infermeta/backward.h的PixelUnshuffleGradInferMeta函数后面增加函数声明
void PreluGradInferMeta(const MetaTensor& x,
const MetaTensor& y,
MetaTensor* dx,
MetaTensor* dy);
There was a problem hiding this comment.
2. PixelUnshuffleGradInferMeta
收到，已添加
|
ci 已过，辛苦 @heavyrain-lzy review 一下~ |
heavyrain-lzy
approved these changes
Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
support auto generate for prelu