Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fused_linear_param_grad_add_kernel #51805

Merged
merged 11 commits into from
Mar 22, 2023

Conversation

sneaxiy
Copy link
Collaborator

@sneaxiy sneaxiy commented Mar 17, 2023

PR types

Performance optimization

PR changes

OPs

Describe

Add fused_linear_param_grad_add_kernel for GPT performance optimization.

@sneaxiy sneaxiy force-pushed the add_fused_linear_param_grad_add branch from e69115a to 115cfb1 Compare March 18, 2023 00:53
@sneaxiy sneaxiy requested a review from ForFishes March 21, 2023 13:44
Copy link
Member

@ForFishes ForFishes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sneaxiy sneaxiy requested a review from zyfncg March 22, 2023 03:06
#include "paddle/phi/kernels/fusion/fused_linear_param_grad_add_kernel.h"

#if defined(PADDLE_WITH_CUDA) && CUDA_VERSION >= 11060
#include "paddle/fluid/operators/fused/fused_gemm_epilogue_op.h"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里不能在include fluid头文件了,已经在编译单独的so了

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

线下讨论,将在下一个PR里修复。感谢指出。

@sneaxiy sneaxiy merged commit f59c5d8 into PaddlePaddle:develop Mar 22, 2023
@sneaxiy sneaxiy deleted the add_fused_linear_param_grad_add branch March 22, 2023 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants