Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimizing setup.py develop command #51528

Merged
merged 8 commits into from
Mar 15, 2023

Conversation

risemeup1
Copy link
Contributor

@risemeup1 risemeup1 commented Mar 12, 2023

PR types

Performance optimization

PR changes

Others

Describe

Pcard-67010
此PR将egg -> Paddle/build/python 改为 egg -> Paddle/python,并将import paddle所依赖的.so文件和protobuf生成的文件移动到源码,实现改动Paddle/python源码直接修改包之后不用再安装就能生效。

@paddle-bot
Copy link

paddle-bot bot commented Mar 12, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@risemeup1 risemeup1 force-pushed the optimize_setup_develop branch from 825cf8e to 829f785 Compare March 12, 2023 13:14
@@ -0,0 +1 @@
*.so*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

建议规范一下编译中间产物的位置

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好的

Copy link
Contributor

@zhiqiu zhiqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@risemeup1 risemeup1 merged commit e4e3675 into PaddlePaddle:develop Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants