add assign composite backward op #51430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
Charles-hit
reviewed
Mar 14, 2023
| @@ -41,14 +43,16 @@ def test_forward(self): | |||
|
|
|||
| def test_backward(self): | |||
| paddle.enable_static() | |||
| self.check_grad(['X'], 'Out', check_eager=True) | |||
| self.check_grad(['X'], 'Out', check_eager=True, check_prim=True) | |||
There was a problem hiding this comment.
pr标注下原算子缺少bfloat16单测，所以组合算子也没有进行测试
Charles-hit
previously approved these changes
Mar 14, 2023
| template <typename T> | ||
| void assign_grad(const Tensor& out_grad, Tensor* x_grad) { | ||
| if (x_grad) { | ||
| auto res = assign<T>(out_grad); |
There was a problem hiding this comment.
it's can use by_pass like subtract_grad
xiaoguoguo626807
approved these changes
Mar 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
Others
Describe
add assign composite backward op
not supporting bfloat16 tests since original op neither supports.