【PaddlePaddle Hackathon 第四期】No.6：为 Paddle 新增 ldexp API #51395

longranger2 · 2023-03-09T00:05:17Z

PR types

New features

PR changes

APIs

Description

为 Paddle 新增 ldexp API

Details

Tracking Issue: #51281
RFC: PaddlePaddle/community#407
CN-Docs: PaddlePaddle/docs#5925

fix math.py

paddle-bot · 2023-03-09T00:05:21Z

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

luotao1 · 2023-03-29T07:04:12Z

请解决下冲突

paddle-ci-bot · 2023-04-24T03:30:50Z

Sorry to inform you that d182aa0's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

luotao1 · 2023-06-02T03:18:30Z

你可以看下，torch是不是不管x输入是int还是float，y都是float？#51395 (comment) 如果是这样的话，需要改RFC文档
是的，不管输入的是float还是int，输出都是float32，我去修改下RFC文档

>>> a = torch.ones([2], dtype=torch.float64)
>>> torch.ldexp(a, torch.tensor([-2])).dtype
torch.float64

输出是float32或float64，不是只有float32，RFC也需要对应修改，放上例子

luotao1 · 2023-06-02T03:22:53Z

单测中需要加一下输出类型的检查

longranger2 · 2023-06-02T05:50:03Z

你可以看下，torch是不是不管x输入是int还是float，y都是float？#51395 (comment) 如果是这样的话，需要改RFC文档
是的，不管输入的是float还是int，输出都是float32，我去修改下RFC文档
>>> a = torch.ones([2], dtype=torch.float64)
>>> torch.ldexp(a, torch.tensor([-2])).dtype
torch.float64
输出是float32或float64，不是只有float32，RFC也需要对应修改，放上例子

好的👌

单测中需要加一下输出类型的检查

好的👌

longranger2 · 2023-06-02T07:57:22Z

还有一个问题：paddle.ldexp是否需要与torch.ldexp进行对齐呢？

torch.ldexp(input, other)要求输入的两个参数都是要求tensor，这样的话，就需要修改下paddle.ldexp(x,y)中y的输入类型，也设置为tensor

luotao1 · 2023-06-02T08:10:20Z

paddle.ldexp(x,y)中y的输入类型，也设置为tensor

好的，建议对齐

longranger2 · 2023-06-02T14:11:17Z

同时提一个paddle.pow 在负数输入时和torch不一致的issue吧 #51395 (comment)

已提交Issue：#54314

luotao1

LGTM

luotao1 · 2023-06-03T05:38:11Z

python/paddle/tensor/math.py

+            x = paddle.to_tensor([1, 2, 3], dtype='float32')
+            y = paddle.to_tensor([2, 3, 4], dtype='int32')
+            res = paddle.ldexp(x, y)
+            print(res)


示例可以多举一个。比如 y = paddle.to_tensor([2]，这样有broadcast的例子了

已经添加好了～

jeff41404 · 2023-06-05T04:55:27Z

python/paddle/tensor/math.py

+    if x.dtype == paddle.float64 or y.dtype == paddle.float64:
+        out_dtype = paddle.float64
+    else:
+        out_dtype = paddle.float32


it is better to use out_dtype = paddle.get_default_dtype() ?

luotao1 · 2023-06-05T09:39:13Z

请解决下冲突

longranger2 · 2023-06-06T03:35:44Z

@luotao1 @jeff41404 已经修改好了，辛苦review下～

jeff41404

LGTM

python/paddle/tensor/math.py

add note for code description Co-authored-by: zachary sun <70642955+sunzhongkai588@users.noreply.github.com>

sunzhongkai588

LGTM for docs，请提供中文文档～

longranger2 added 5 commits March 7, 2023 21:05

add ldexp api

f7e08fb

Merge branch 'PaddlePaddle:develop' into ldexp

fc3e18e

fix ldexp

f5021b8

Update math.py

79c798a

fix math.py

Merge branch 'PaddlePaddle:develop' into ldexp

677b152

paddle-bot bot added contributor External developers status: proposed labels Mar 9, 2023

longranger2 mentioned this pull request Mar 9, 2023

【PaddlePaddle Hackathon 第四期】任务总览 #51281

Closed

luotao1 assigned luotao1 and Ligoml Mar 9, 2023

longranger2 changed the title ~~【PaddlePaddle Hackathon 第四期】No1：为 Paddle 新增 ldexp API~~ 【PaddlePaddle Hackathon 第四期】No6：为 Paddle 新增 ldexp API Mar 9, 2023

luotao1 added the API label Mar 10, 2023

paddle-bot bot removed the status: proposed label Mar 10, 2023

longranger2 changed the title ~~【PaddlePaddle Hackathon 第四期】No6：为 Paddle 新增 ldexp API~~ 【PaddlePaddle Hackathon 第四期】No.6：为 Paddle 新增 ldexp API Mar 13, 2023

Ligoml requested a review from luotao1 March 14, 2023 02:40

Merge branch 'develop' into ldexp

1d2c77d

longranger2 added 2 commits April 6, 2023 22:30

Merge branch 'ldexp' of https://github.com/longranger2/Paddle into ldexp

1e0a6d7

fix bug

d182aa0

longranger2 added 4 commits May 15, 2023 16:34

rewrite the ldexp

44aa6dd

Simplify ldexp implementation

dc62e14

Simplify ldexp implementation

344ff06

Merge branch 'develop' into ldexp

7d30779

luotao1 added the PaddlePaddle Hackathon label May 17, 2023

longranger2 added 4 commits May 17, 2023 22:00

fix codestyle

6ca9231

Update math.py

c9d0f91

Update math.py

cfdc729

Merge branch 'PaddlePaddle:develop' into ldexp

f056dc1

longranger2 requested a review from luotao1 June 2, 2023 07:57

longranger2 added 2 commits June 2, 2023 12:58

modify the ldexp function and add the dtype check of output

853aae9

Update test_ldexp.py

91d61f0

luotao1 mentioned this pull request Jun 3, 2023

paddle.pow与torch.pow计算不一致 #54314

Closed

luotao1 previously approved these changes Jun 3, 2023

View reviewed changes

jeff41404 reviewed Jun 5, 2023

View reviewed changes

longranger2 added 2 commits June 5, 2023 07:06

fix the dtype

b841b89

Merge branch 'ldexp' of https://github.com/longranger2/Paddle into ldexp

e44655e

longranger2 dismissed luotao1’s stale review via e44655e June 5, 2023 07:11

Merge branch 'develop' into ldexp

a642882

longranger2 requested review from jeff41404 and luotao1 June 5, 2023 12:06

fix codestyle

ca3fae5

jeff41404 previously approved these changes Jun 6, 2023

View reviewed changes

luotao1 assigned sunzhongkai588 Jun 6, 2023

sunzhongkai588 reviewed Jun 6, 2023

View reviewed changes

python/paddle/tensor/math.py Outdated Show resolved Hide resolved

Update python/paddle/tensor/math.py

3b576b1

add note for code description Co-authored-by: zachary sun <70642955+sunzhongkai588@users.noreply.github.com>

longranger2 dismissed jeff41404’s stale review via 3b576b1 June 6, 2023 11:28

longranger2 requested review from sunzhongkai588 and jeff41404 June 7, 2023 01:28

sunzhongkai588 approved these changes Jun 7, 2023

View reviewed changes

luotao1 merged commit cb2476c into PaddlePaddle:develop Jun 7, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

【PaddlePaddle Hackathon 第四期】No.6：为 Paddle 新增 ldexp API #51395

【PaddlePaddle Hackathon 第四期】No.6：为 Paddle 新增 ldexp API #51395

longranger2 commented Mar 9, 2023 •

edited

Loading

paddle-bot bot commented Mar 9, 2023

luotao1 commented Mar 29, 2023

paddle-ci-bot bot commented Apr 24, 2023

luotao1 commented Jun 2, 2023 •

edited

Loading

luotao1 commented Jun 2, 2023

longranger2 commented Jun 2, 2023

longranger2 commented Jun 2, 2023 •

edited

Loading

luotao1 commented Jun 2, 2023

longranger2 commented Jun 2, 2023

luotao1 left a comment

luotao1 Jun 3, 2023

longranger2 Jun 5, 2023

jeff41404 Jun 5, 2023

longranger2 Jun 5, 2023

luotao1 commented Jun 5, 2023

longranger2 commented Jun 6, 2023

jeff41404 left a comment

sunzhongkai588 left a comment

【PaddlePaddle Hackathon 第四期】No.6：为 Paddle 新增 ldexp API #51395

【PaddlePaddle Hackathon 第四期】No.6：为 Paddle 新增 ldexp API #51395

Conversation

longranger2 commented Mar 9, 2023 • edited Loading

PR types

PR changes

Description

Details

paddle-bot bot commented Mar 9, 2023

luotao1 commented Mar 29, 2023

paddle-ci-bot bot commented Apr 24, 2023

luotao1 commented Jun 2, 2023 • edited Loading

luotao1 commented Jun 2, 2023

longranger2 commented Jun 2, 2023

longranger2 commented Jun 2, 2023 • edited Loading

luotao1 commented Jun 2, 2023

longranger2 commented Jun 2, 2023

luotao1 left a comment

Choose a reason for hiding this comment

luotao1 Jun 3, 2023

Choose a reason for hiding this comment

longranger2 Jun 5, 2023

Choose a reason for hiding this comment

jeff41404 Jun 5, 2023

Choose a reason for hiding this comment

longranger2 Jun 5, 2023

Choose a reason for hiding this comment

luotao1 commented Jun 5, 2023

longranger2 commented Jun 6, 2023

jeff41404 left a comment

Choose a reason for hiding this comment

sunzhongkai588 left a comment

Choose a reason for hiding this comment

longranger2 commented Mar 9, 2023 •

edited

Loading

luotao1 commented Jun 2, 2023 •

edited

Loading

longranger2 commented Jun 2, 2023 •

edited

Loading