Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add split and split_with_num composite rule #51341

Merged
merged 11 commits into from
Mar 14, 2023

Conversation

ccrrong
Copy link
Contributor

@ccrrong ccrrong commented Mar 8, 2023

PR types

Others

PR changes

Others

Describe

add split and split_with_num grad composite rule

@paddle-bot
Copy link

paddle-bot bot commented Mar 8, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

"composite grad for now. "));
} else {
if (sections.size() > 0) {
VLOG(6) << "Runing split_grad composite func";
Copy link
Contributor

@Charles-hit Charles-hit Mar 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

split_grad跟split_with_num_grad是一种情况,可以合成一个函数

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Contributor

@xiaoguoguo626807 xiaoguoguo626807 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xiaoguoguo626807 xiaoguoguo626807 self-requested a review March 14, 2023 03:15
@xiaoguoguo626807 xiaoguoguo626807 merged commit bb9eb20 into PaddlePaddle:develop Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants