Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable gpups run on rec model #51115

Merged

Conversation

pangengzheng
Copy link
Contributor

@pangengzheng pangengzheng commented Mar 2, 2023

PR types

Others

PR changes

Others

Describe

Enable gpups run on rec model

@paddle-bot
Copy link

paddle-bot bot commented Mar 2, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@pangengzheng pangengzheng changed the title Check gpups on haokanctr Enable gpups run on rec model Mar 3, 2023
zyfncg
zyfncg previously approved these changes Mar 6, 2023
Copy link
Contributor

@zyfncg zyfncg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for setup.py.in

YuanRisheng
YuanRisheng previously approved these changes Mar 6, 2023
@@ -593,9 +593,11 @@ if '${WITH_CINN}' == 'ON':

if '${WITH_PSLIB}' == 'ON':
shutil.copy('${PSLIB_LIB}', libs_path)
shutil.copy('${JVM_LIB}', libs_path)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setup.py也要对应同步改动,可参考#51082

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@pangengzheng pangengzheng dismissed stale reviews from YuanRisheng and zyfncg via 68672eb March 7, 2023 03:44
Copy link
Contributor

@risemeup1 risemeup1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pangengzheng pangengzheng requested review from zyfncg and removed request for zmxdream, chenwhql and danleifeng March 7, 2023 06:21
Copy link
Contributor

@zyfncg zyfncg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for setup.py.in

@danleifeng danleifeng merged commit 32f369a into PaddlePaddle:develop Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants