Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a bug calculate_output in eagerChecker #51069

Merged
merged 1 commit into from
Mar 2, 2023

Conversation

Vvsmile
Copy link
Contributor

@Vvsmile Vvsmile commented Mar 1, 2023

PR types

Others

PR changes

Others

Describe

fix a bug calculate_output in eagerChecker,the eager_dygraph_outs needs is produced by the _calc_python_api_output function of fp16, but ref_eager_dygraph_outs which is produced by the _calc_python_api_output function of fp32 should be needed in the branch of is_fp16_compared_with_fp32()

@paddle-bot
Copy link

paddle-bot bot commented Mar 1, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@ZzSean
Copy link
Contributor

ZzSean commented Mar 1, 2023

PR描述下修改的原因

Copy link
Contributor

@ZzSean ZzSean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZzSean ZzSean merged commit ff7ce2f into PaddlePaddle:develop Mar 2, 2023
@Vvsmile
Copy link
Contributor Author

Vvsmile commented Mar 2, 2023

PR描述下修改的原因

done

@Vvsmile Vvsmile deleted the fix_op_test_in_eager_output branch March 11, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants