[AMP OP&Test] Update unittest of fp16 for slice op #51036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
ZzSean
changed the title
ZzSean
reviewed
Mar 1, 2023
| @@ -510,7 +510,7 @@ def config(self): | |||
| def test_check_output(self): | |||
| place = core.CUDAPlace(0) | |||
| if core.is_float16_supported(place): | |||
| self.check_output_with_place(place, atol=1e-5, check_prim=True) | |||
There was a problem hiding this comment.
- 1e-3是默认值，可以直接删掉
- test_check_output中可以直接调self.check_output
下同
There was a problem hiding this comment.
check_grad_with_place里的max_relative_error默认值也是1e-3吗？
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
Update the threshold of fp16 unittest for slice op.