【AMP OP&Test】unit test for accuracy_op #51009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
ZzSean
reviewed
Feb 28, 2023
| @@ -30,7 +31,7 @@ void AccuracyRawKernel(const Context& dev_ctx, | |||
| DenseTensor* total) { | |||
| int* correct_data = dev_ctx.template Alloc<int>(correct); | |||
| int* total_data = dev_ctx.template Alloc<int>(total); | |||
| float* accuracy_data = dev_ctx.template Alloc<float>(accuracy); | |||
ZzSean
reviewed
Feb 28, 2023
| @@ -45,12 +45,20 @@ def setUp(self): | |||
| } | |||
|
|
|||
| def init_dtype(self): | |||
| pass | |||
| self.dtype = np.float32 | |||
There was a problem hiding this comment.
这可以不改，默认是FP32的话，下面的TestAccuracyOpFp32也不用加了
There was a problem hiding this comment.
这个应该是本来上面设置的FP32，不知道默认是不是。我统一到init_dtype中
| self.dtype = np.uint16 | ||
|
|
||
| def test_check_output(self): | ||
| self.check_output(atol=1e-2) |
zhangbopd
changed the title
zhangbopd
force-pushed
the
test_accuracy_op
branch
from
744fd52
to
b4615b1
Compare
ZzSean
reviewed
Mar 1, 2023
| self.check_output() | ||
|
|
||
|
|
||
| def create_test_fp16_class(parent): |
| self.check_output() | ||
|
|
||
|
|
||
| def create_test_fp16_class(parent): |
There was a problem hiding this comment.
只有一个case的话，是不是不用定义这样一个类？反而变得复杂了
| globals()[cls_name] = TestAccuracyOpFp16 | ||
|
|
||
|
|
||
| def create_test_bf16_class(parent): |
zhangbopd
force-pushed
the
test_accuracy_op
branch
from
ab280d9
to
a63d5e1
Compare
ZzSean
reviewed
Mar 6, 2023
| @@ -51,6 +52,14 @@ def test_check_output(self): | |||
| self.check_output() | |||
|
|
|||
|
|
|||
| class TestAccuracyOpFp32(TestAccuracyOp): | |||
luotao1
approved these changes
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe