Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fp16] suppot fp16 in argmin #50858

Merged

Conversation

enkilee
Copy link
Contributor

@enkilee enkilee commented Feb 24, 2023

PR types

Others

PR changes

APIs

Describe

@paddle-bot
Copy link

paddle-bot bot commented Feb 24, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot
Copy link

paddle-bot bot commented Feb 24, 2023

很抱歉,经过我们的反复讨论,你的PR暂未达到合入标准,请阅读飞桨原生算子开发规范,你可以重新提交新的PR,我们先将此PR关闭,感谢你的贡献。
Sorry to inform you that through our discussion, your PR fails to meet the merging standard (Reference: Paddle Custom Operator Design Doc). You can also submit an new one. Thank you.

@enkilee enkilee reopened this Feb 24, 2023
@enkilee enkilee changed the title [fp16] suppot fp16 in argmax and argmin [fp16] suppot fp16 in argmin Feb 24, 2023
zhangting2020
zhangting2020 previously approved these changes Feb 26, 2023
Copy link
Contributor

@zhangting2020 zhangting2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1
Copy link
Contributor

luotao1 commented Feb 27, 2023

@enkilee 请解决下冲突

@luotao1 luotao1 merged commit 69d49ab into PaddlePaddle:develop Feb 28, 2023
@enkilee enkilee deleted the fix-fp16-dtype-checking-for-argmin-op branch March 16, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants