[Prim]fix attrs loss in creating op #50780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JiabinYang
reviewed
Feb 22, 2023
| if self._has_kernel(type): | ||
| self.desc.infer_var_type(self.block.desc) | ||
| self.desc.infer_shape(self.block.desc) | ||
|
|
||
| def _has_kernel(self, op_type): | ||
| return op_type not in self.OP_WITHOUT_KERNEL_SET | ||
|
|
||
| def _get_runtime_attrs(self): |
There was a problem hiding this comment.
Add comments to avoid other one using this.
| @@ -656,8 +656,10 @@ def expand_nested_list(xs): | |||
| outputs[op.output_names[i]] = op.output(op.output_names[i]) | |||
|
|
|||
| attrs = {} | |||
| for name in sorted(op.attr_names): | |||
| attrs[name] = op.attr(name) | |||
| runtime_attrs = op._get_runtime_attrs() | |||
There was a problem hiding this comment.
Add comments to explain why we need this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
Others
Describe
When setting composite forward ops, during creating operator, there may be some attrs loss which should be added.
For example, after constructing program of op dropout, attrs seed and fix_seed will not appear in program. In this case, when we need to copy the same op from origin program, attrs seed and fix_seed cannot be got by op.attr_names. So we use special member property defined during origin op initialization.