Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate xpu_embedding_with_eltwise_add_fuse_pass #50590

Merged
merged 7 commits into from
Feb 23, 2023

Conversation

csy0225
Copy link
Contributor

@csy0225 csy0225 commented Feb 17, 2023

PR types

Performance optimization

PR changes

Others

Describe

  1. Migrate xpu_embedding_with_eltwise_add_fuse_pass from lite, to optimize the series of ernie models.
    Pattern:

image

  1. 修复 delete_dropout_op_pass 中在如下情况下重复删除 dropout input tensor 引起的 bug:
    image

@paddle-bot
Copy link

paddle-bot bot commented Feb 17, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot
Copy link

paddle-bot bot commented Feb 17, 2023

❌ The PR is not created using PR's template. You can refer to this Demo.
Please use PR's template, it helps save our maintainers' time so that more developers get helped.

@csy0225 csy0225 force-pushed the xpu_pass_migrate branch 3 times, most recently from 72d665e to 0a96626 Compare February 21, 2023 02:46
@csy0225 csy0225 changed the title migrate pass1 Migrate xpu_embedding_with_eltwise_add_fuse_pass Feb 21, 2023
zhupengyang
zhupengyang previously approved these changes Feb 22, 2023
Copy link
Contributor

@zhupengyang zhupengyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@chenwhql chenwhql left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for PADDLE_ENFORCE

@zhupengyang zhupengyang merged commit 8d325d8 into PaddlePaddle:develop Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants