[Tensor Operants & Prim] Tensor arithmetic operants support right scalar type #50563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… support_add_minus_divide
… support_add_minus_divide
… support_scalar_type
… support_scalar_type
|
你的PR提交成功，感谢你对开源项目的贡献! |
… support_scalar_type
… support_scalar_type
jiahy0825
force-pushed
the
support_scalar_type
branch
from
2d26e3a
to
04dbf27
Compare
chenwhql
approved these changes
Feb 23, 2023
zyfncg
approved these changes
Feb 23, 2023
zyfncg
reviewed
Feb 23, 2023
Comment on lines
+46
to
+50
| 'fill_constant', | ||
| 'elementwise_mul', | ||
| 'fill_constant', | ||
| 'elementwise_add', | ||
| 'elementwise_mul', |
There was a problem hiding this comment.
此处表示的是算子的调用顺序，并未重复
Here represents the order of calling operators.
YuanRisheng
approved these changes
Feb 23, 2023
JiabinYang
reviewed
Feb 23, 2023
| - add | ||
| - subtract | ||
| - multiply | ||
| - divide | ||
| - unsqueeze | ||
| - pow |
There was a problem hiding this comment.
maybe we don't need this?
There was a problem hiding this comment.
以加法为例，虽然用户不再需要调用 add 函数，可以直接调用 + 运算符。
但是重载后的 + 操作，实际依赖的还是 add 函数，因此需要保留这几项，自动生成 add 函数的声明。
Although users could invoke the + operant directly without calling the add function, in fact, the overloaded + operant relies on the add function. Hence, we need to keep these items to generate an add declaration automatically.
jiahy0825
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
Others
Describe
本 PR 工作项点：
Items of this PR:
Tensor +-*/ Scalar