Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PHI decoupling] move mixed_vector from fluid to phi #50282

Merged
merged 1 commit into from
Feb 8, 2023
Merged

[PHI decoupling] move mixed_vector from fluid to phi #50282

merged 1 commit into from
Feb 8, 2023

Conversation

huangjiyi
Copy link
Member

PR types

Others

PR changes

Others

Describe

  • 将 mixed_vector 相关文件从 fluid/framework/ 移动到 phi/core/ 和 phi/tests/core/ 下
  • mixed_vector 对 memory 的依赖没有解除

@paddle-bot
Copy link

paddle-bot bot commented Feb 7, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

XieYunshen
XieYunshen approved these changes Feb 7, 2023
View reviewed changes
Copy link
Contributor

@XieYunshen XieYunshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
单测重命名

zhwesky2010
zhwesky2010 approved these changes Feb 7, 2023
View reviewed changes
Copy link
Contributor

@zhwesky2010 zhwesky2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for parallel_UT.py

XiaoguangHu01
XiaoguangHu01 approved these changes Feb 7, 2023
View reviewed changes
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YuanRisheng YuanRisheng merged commit 35d7d1f into PaddlePaddle:develop Feb 8, 2023
@huangjiyi
Copy link
Member Author

@huangjiyi
Copy link
Member Author

@YuanRisheng

@YuanRisheng YuanRisheng mentioned this pull request Feb 20, 2023
Closed
@huangjiyi huangjiyi deleted the decouple_mixed_vector branch March 8, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuanRisheng YuanRisheng YuanRisheng approved these changes

@XieYunshen XieYunshen XieYunshen approved these changes

@XiaoguangHu01 XiaoguangHu01 XiaoguangHu01 approved these changes

@zhwesky2010 zhwesky2010 zhwesky2010 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@huangjiyi @YuanRisheng @XieYunshen @XiaoguangHu01 @zhwesky2010