Extract apply_backward_pass to backward.py #5026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reyoung
force-pushed
the
feature/extract_backward
branch
from
ffcd758
to
5daec7b
Compare
Rename apply_backward_pass to append_backward_ops
jacquesqiao
reviewed
Oct 24, 2017
| @@ -90,45 +92,6 @@ def _get_accumulator(self, name, param): | |||
| format(name, param.name)) | |||
| return self._accumulators[name][param.name] | |||
|
|
|||
| def create_backward_pass(self, loss, parameter_list=None, no_grad_set=None): | |||
There was a problem hiding this comment.
我觉得如果要删，也可以专门用一个pr来删，包括design一起修改，先提出来就行了
reyoung
force-pushed
the
feature/extract_backward
branch
from
f93c8f7
to
e7da76f
Compare
jacquesqiao
approved these changes
Oct 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename apply_backward_pass to append_backward_ops