Remove axis in some elementwise api #50190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
jiahy0825
reviewed
Feb 7, 2023
Comment on lines
-630
to
+605
| if in_dygraph_mode(): | ||
| return _C_ops.add_(x, y) | ||
| else: | ||
| out = _elementwise_op_in_dygraph(x, y, axis=axis, op_name=op_type) | ||
| return out | ||
| return _C_ops.add_(x, y) |
There was a problem hiding this comment.
本函数的前置逻辑，也可以删除，后续的几个函数同理
op_type = 'elementwise_add_'
axis = -1
| # This rule is obscure, so we maybe replace it by adding new design in the future. | ||
| if is_inplaced and ( | ||
| self.forward_api_name[-1] != '_' | ||
| or self.forward_api_name == 'assign_out_' |
There was a problem hiding this comment.
此处为什么要特殊处理
Why do we need this special case?
There was a problem hiding this comment.
这个属于inplace处理机制的遗留问题，一般对于有反向的inplace接口都需要做InplaceCheck处理，但assign_out_早期没有加InplaceCheck导致现在加上就会有不兼容问题，所以暂时只能通过黑名单来跳过
YuanRisheng
approved these changes
Feb 7, 2023
chenwhql
approved these changes
Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
APIs
Describe
elementwise系列算子中的axis目前已不再推荐使用，为了减少该类接口不规范的使用，本PR对部分elementwise接口中的axis参数进行了清理，并删除了一些不再使用的接口。