Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix UFA非法地址访问(UFA illegal address access) of case3: paddle.crop #49994

Merged
merged 3 commits into from
Feb 1, 2023
Merged

Fix UFA非法地址访问(UFA illegal address access) of case3: paddle.crop #49994

merged 3 commits into from
Feb 1, 2023

Conversation

RedContritio
Copy link
Contributor

PR types

Bug fixes

PR changes

OPs

Describe

Solution

  • 添加了对 offset 的下限检查
  • 添加了对 offset+shape 的下限检查

@paddle-bot
Copy link

paddle-bot bot commented Jan 21, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Jan 21, 2023
@luotao1 luotao1 mentioned this pull request Jan 22, 2023
Closed
wanghuancoder
wanghuancoder reviewed Jan 30, 2023
View reviewed changes
Copy link
Contributor

@wanghuancoder wanghuancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

为这个case加个单测吧

@RedContritio
Copy link
Contributor Author

为这个case加个单测吧

已添加

wanghuancoder
wanghuancoder approved these changes Feb 1, 2023
View reviewed changes
Copy link
Contributor

@wanghuancoder wanghuancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HexToString
Copy link
Contributor

LGTM

@luotao1 luotao1 merged commit 34bf3d0 into PaddlePaddle:develop Feb 1, 2023
pangengzheng pushed a commit to pangengzheng/Paddle that referenced this pull request Feb 2, 2023
@RedContritio @pangengzheng
Fix UFA非法地址访问(UFA illegal address access) of case3: paddle.crop (Padd…
75680d7 
…lePaddle#49994)

* add range check for crop_kernel

* remove shape negative check

* add unittest
@RedContritio RedContritio deleted the crop branch February 13, 2023 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wanghuancoder wanghuancoder wanghuancoder approved these changes

Assignees

@luotao1 luotao1

@wanghuancoder wanghuancoder

@HexToString HexToString

Labels
contributor External developers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RedContritio @HexToString @wanghuancoder @luotao1