-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 空指针 (Null pointer) of case8: paddle.slice #49979
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
为这个case加个单测吧
已添加 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
x = paddle.to_tensor(np.reshape(array, [0]), dtype='float32') | ||
out = paddle.slice(x, axes=[0], starts=[0], ends=[0]) | ||
self.assertEqual(out.numel(), 0) | ||
# self.assertEqual(out.shape) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
无用的注释可以去掉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RedContritio 可以在别的PR中去掉873行无用的注释,这个PR先merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
收到
* add check for input of slice * add unittest
PR types
Bug fixes
PR changes
OPs
Describe
Solution
要求
axes
,starts
和ends
长度相同