Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 空指针 (Null pointer) of case8: paddle.slice #49979

Merged
merged 2 commits into from
Feb 1, 2023
Merged

Fix 空指针 (Null pointer) of case8: paddle.slice #49979

merged 2 commits into from
Feb 1, 2023

Conversation

RedContritio
Copy link
Contributor

PR types

Bug fixes

PR changes

OPs

Describe

Solution

要求 axes, startsends 长度相同

@paddle-bot-old paddle-bot-old bot added the contributor External developers label Jan 21, 2023
@luotao1 luotao1 mentioned this pull request Jan 22, 2023
Copy link
Contributor

@wanghuancoder wanghuancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

为这个case加个单测吧

@RedContritio
Copy link
Contributor Author

为这个case加个单测吧

已添加

Copy link
Contributor

@wanghuancoder wanghuancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

x = paddle.to_tensor(np.reshape(array, [0]), dtype='float32')
out = paddle.slice(x, axes=[0], starts=[0], ends=[0])
self.assertEqual(out.numel(), 0)
# self.assertEqual(out.shape)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

无用的注释可以去掉

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RedContritio 可以在别的PR中去掉873行无用的注释,这个PR先merge

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

收到

@luotao1 luotao1 merged commit 3cf50f9 into PaddlePaddle:develop Feb 1, 2023
pangengzheng pushed a commit to pangengzheng/Paddle that referenced this pull request Feb 2, 2023
@RedContritio RedContritio deleted the slice branch February 13, 2023 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants