Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Pglbox2.0] merge gpugraph to develop #49946

Merged
merged 52 commits into from
Jan 30, 2023
Merged

Conversation

zmxdream
Copy link
Contributor

@zmxdream zmxdream commented Jan 19, 2023

PR types

New features

PR changes

Others

Describe

日志降级
新增paddle.incubate.operators.unzip
修复dense参数卡住问题
增加 get_epoch_finish python端接口
修复barrier不生效的问题

chao9527 and others added 30 commits December 24, 2022 13:42
* add set slot_num_for_pull_feature for psgpuwarper
* add get_epoch_finish interface

* add return

* delete return
* fix miss key for error dataset

* fix miss key for error dataset

Co-authored-by: yangjunchao <yangjunchao@baidu.com>
Co-authored-by: yangjunchao <yangjunchao@baidu.com>
* check node&feature format when loading

* check node&feature format when loading (2£ (2)
@paddle-bot
Copy link

paddle-bot bot commented Jan 19, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot
Copy link

paddle-bot bot commented Jan 19, 2023

❌ The PR is not created using PR's template. You can refer to this Demo.
Please use PR's template, it helps save our maintainers' time so that more developers get helped.

Copy link
Contributor

@danleifeng danleifeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zmxdream zmxdream changed the title Pglbox2 [Pglbox2.0] merge gpugraph to develop Jan 30, 2023
Copy link
Contributor

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for unity_build_rule.cmake

Copy link
Contributor

@JiabinYang JiabinYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTM

# limitations under the License.

from paddle.fluid.data_feeder import check_variable_and_dtype
from paddle.fluid.layer_helper import LayerHelper
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fluid API再被移除,这里是否一定需要引用 paddle.fluid

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个incubate目录下的其余API目前也仍然都在使用FLUID.得后续统一迁移,这个PR暂时先不修改了


Args:
input (Variable): The zipped input, 2-D LodTensor with shape [N, M].
lod (Variable): The original lod of unzipped input, 1-D LodTensor with shape[K].
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

对外已经不在提LoDTensor、LoD概念,这里docs和参数命名需要依据含义再改下

Copy link
Contributor Author

@zmxdream zmxdream Jan 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个OP是内部业务使用,主要就是根据LOD信息来操作INPUT,不打算暴露,这里的LodTensor的说法,可以再提个pr修改,暂时这个pr先豁免

Copy link
Contributor

@qingqing01 qingqing01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve for API

@zmxdream zmxdream merged commit cb525d4 into PaddlePaddle:develop Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.