【Prim】Add multiply,expand,div vjp rules #49831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
cxxly
force-pushed
the
prim_mul_expand_exp
branch
14 times, most recently
from
24ea6b7
to
7415a85
Compare
JiabinYang
reviewed
Jan 15, 2023
| // Reduced axes | ||
| for (std::size_t i = 0; i < src_shape.size(); i++) { | ||
| if (src_shape[i] == 1 && dst_shape[i] > 1) { | ||
| result.push_back(i); |
There was a problem hiding this comment.
This may be miss some case if x, y has 1 as extra rank
cxxly
force-pushed
the
prim_mul_expand_exp
branch
5 times, most recently
from
2c79d11
to
ca30b38
Compare
cxxly
force-pushed
the
prim_mul_expand_exp
branch
from
ca30b38
to
bbe3480
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe