[Zero-Dim] support input 0D for paddle.moveaxis / quantile #49813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
zhwesky2010
force-pushed
the
0D_moveaxis
branch
from
149bf9b
to
2a9c181
Compare
zhwesky2010
changed the title
zhwesky2010
force-pushed
the
0D_moveaxis
branch
8 times, most recently
from
de3f0cb
to
89d9aba
Compare
zhwesky2010
force-pushed
the
0D_moveaxis
branch
from
89d9aba
to
6170d10
Compare
wawltor
reviewed
Jan 18, 2023
| raise ValueError("Each elemment of 'source' must be unique!") | ||
| count = Counter(dst).most_common(1) | ||
| if count[0][1] > 1: | ||
| if len(dst) != len(set(dst)): |
There was a problem hiding this comment.
这里的改动看起来是一个不兼容修改，会不会出现
(0, 0) -> (1, 1) 情况
出现这种情况API能正常执行吗？
There was a problem hiding this comment.
这个作用是用来查重的，如果有重复的：
raise ValueError("Each elemment of 'source' must be unique!")
之前也是这个逻辑，这里改了下写法
heliqi
approved these changes
Jan 18, 2023
This was referenced Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
APIs
Describe
[Zero-Dim] support input 0D for paddle.moveaxis/quantile