[D2SCinn]Fix self.infer_program always build cinn pass without cache #49696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
Aurelius84
commented
Jan 10, 2023
| @@ -280,23 +280,32 @@ def _train_program(self): | |||
|
|
|||
| @LazyInitialized | |||
| def _infer_program(self): | |||
| return self._create_program(is_infer_mode=True) | |||
| program = self._create_program(is_infer_mode=True) | |||
There was a problem hiding this comment.
若内部开发者想获取原生program，可以调用self._create_program
Aurelius84
commented
Jan 11, 2023
| @@ -317,62 +346,6 @@ def _train_pure_fp16_forward_backward_program(self): | |||
| program = self._create_forward_backward_train_pure_fp16_program() | |||
| return program | |||
|
|
|||
| @property | |||
| def whole_program(self): | |||
| if self.training: | |||
There was a problem hiding this comment.
删除了此接口，与program重复了
Aurelius84
commented
Jan 11, 2023
| return names | ||
|
|
||
| @property | ||
| def whole_program_id(self): |
There was a problem hiding this comment.
删除了此接口，与program_id重复了
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Function optimization
PR changes
APIs
Describe
优化了 self.infer_program 在每次被调用时都会重复的_build_infer_program，导致性能下降。
将_build_infer_program 逻辑下放到 self._XX 函数中。因为已经提供了self._create_XXX_program接口获取原生的program，因此此处采取了当前方案。