Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CUDA12.0 integration #49539

Merged

Conversation

zlsh80826
Copy link
Collaborator

PR types

Others

PR changes

Others

Describe

Some of CUDA toolkits APIs were deprecated and removed on cuda-12. This PR is to make Paddle can be compiled with cuda-12.

@paddle-bot
Copy link

paddle-bot bot commented Jan 4, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Jan 4, 2023
@zlsh80826 zlsh80826 added NVIDIA and removed contributor External developers status: proposed labels Jan 4, 2023
@paddle-bot-old paddle-bot-old bot added the contributor External developers label Jan 4, 2023
@zlsh80826 zlsh80826 force-pushed the zlsh80826/cuda-12-integration branch from 85e9b67 to 40a6f5e Compare January 8, 2023 14:47
@zlsh80826 zlsh80826 force-pushed the zlsh80826/cuda-12-integration branch from 40a6f5e to 9bb1349 Compare January 9, 2023 03:13
@zlsh80826
Copy link
Collaborator Author

@Xreki, could you arrange engineers to review this PR?

@@ -20,6 +20,7 @@ namespace platform {
void CudaProfilerInit(const std::string& output_file,
const std::string& output_mode,
const std::string& config_file) {
#if CUDA_VERSION < 11000
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there no need for profiler inition once cuda version was beyond cuda11.0? The pr-description is all about cuda12.0, will this change affect version between cuda11.0 and cuda12.0, such as cuda11.2 ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cudaProfilerInitialize is marked as deprecated from cuda11.0, and it is removed after cuda12.0. So this change will not affect the functionaltiy of cuda 11.x.
https://docs.nvidia.com/cuda/archive/11.0/cuda-runtime-api/group__CUDART__PROFILER__DEPRECATED.html

Copy link
Contributor

@JamesLim-sy JamesLim-sy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JamesLim-sy JamesLim-sy merged commit 1885d55 into PaddlePaddle:develop Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers NVIDIA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants