-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CUDA12.0 integration #49539
CUDA12.0 integration #49539
Conversation
你的PR提交成功,感谢你对开源项目的贡献! |
85e9b67
to
40a6f5e
Compare
40a6f5e
to
9bb1349
Compare
@Xreki, could you arrange engineers to review this PR? |
@@ -20,6 +20,7 @@ namespace platform { | |||
void CudaProfilerInit(const std::string& output_file, | |||
const std::string& output_mode, | |||
const std::string& config_file) { | |||
#if CUDA_VERSION < 11000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there no need for profiler inition once cuda version was beyond cuda11.0? The pr-description is all about cuda12.0, will this change affect version between cuda11.0 and cuda12.0, such as cuda11.2 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cudaProfilerInitialize
is marked as deprecated from cuda11.0, and it is removed after cuda12.0. So this change will not affect the functionaltiy of cuda 11.x.
https://docs.nvidia.com/cuda/archive/11.0/cuda-runtime-api/group__CUDART__PROFILER__DEPRECATED.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR types
Others
PR changes
Others
Describe
Some of CUDA toolkits APIs were deprecated and removed on cuda-12. This PR is to make Paddle can be compiled with cuda-12.