Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor ProcessGroup to support comm context migration & clang compilation #49451

Merged
merged 6 commits into from
Jan 5, 2023
Merged

Refactor ProcessGroup to support comm context migration & clang compilation #49451

merged 6 commits into from
Jan 5, 2023

Conversation

HermitSun
Copy link
Contributor

@HermitSun HermitSun commented Dec 29, 2022 •
edited
Loading

PR types

Others

PR changes

Others

Describe

  1. 重构 ProcessGroup 的类结构以支持后续多流代码的迁移
  2. 避免多个虚函数产生的冲突，以此支持 clang 编译
  3. 清理部分 fluid 依赖，改为 phi 中对应的头文件

@paddle-bot
Copy link

paddle-bot bot commented Dec 29, 2022

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

LiYuRio
LiYuRio previously approved these changes Jan 3, 2023
View reviewed changes
Copy link
Contributor

@LiYuRio LiYuRio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HermitSun HermitSun changed the title Refactor ProcessGroup to support clang compilation Refactor ProcessGroup to support comm context migration & clang compilation Jan 5, 2023
XiaoguangHu01
XiaoguangHu01 approved these changes Jan 5, 2023
View reviewed changes
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

chenwhql
chenwhql approved these changes Jan 5, 2023
View reviewed changes
Copy link
Contributor

@chenwhql chenwhql left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for PADDLE_THROW

@LiYuRio LiYuRio merged commit 1be70bc into PaddlePaddle:develop Jan 5, 2023
@HermitSun HermitSun deleted the collective-pg-scatter branch January 5, 2023 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenwhql chenwhql chenwhql approved these changes

@XiaoguangHu01 XiaoguangHu01 XiaoguangHu01 approved these changes

@LiYuRio LiYuRio LiYuRio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@HermitSun @chenwhql @XiaoguangHu01 @LiYuRio