set_setup_permission #49410
Merged
set_setup_permission #49410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
risemeup1
force-pushed
the
set_permission
branch
from
b672abf to
f7889f1
Compare
zhangbo9674
reviewed
Dec 30, 2022
tools/check_file_diff_approvals.sh
Outdated
| elif [ "${HAS_MODIFIED_SETUP_IN}" == "" ] && [ "${GIT_PR_ID}" != "" ] && [ "${HAS_MODIFIED_SETUP}" != "" ];then | ||
| echo_line="You must have one RD (liujiaodi) approval for setup.py and setup.py.in are not modified synchronously" | ||
| check_approval 1 liujiaodi | ||
| elif [ "${HAS_MODIFIED_SETUP_IN}" != "" ] && [ "${GIT_PR_ID}" != "" ] && [ "${HAS_MODIFIED_SETUP}" != "" ]; then |
There was a problem hiding this comment.
不用修改原始逻辑，新增一条 (modified_setup) || (modified_setup.in && not_modified_setup) approve检查即可
tools/check_file_diff_approvals.sh
Outdated
| if [ "${HAS_MODIFIED_SETUP_IN}" != "" ] && [ "${GIT_PR_ID}" != "" ]; then | ||
| HAS_MODIFIED_SETUP=`git diff --name-only upstream/$BRANCH | grep "${PADDLE_ROOT}/setup.py" || true` | ||
| if [ "${HAS_MODIFIED_SETUP_IN}" != "" ] && [ "${GIT_PR_ID}" != "" ] && [ "${HAS_MODIFIED_SETUP}" == "" ];then | ||
| echo_line="You must have one RD (liujiaodi) approval for setup.py and setup.py.in are not modified synchronously" |
risemeup1
force-pushed
the
set_permission
branch
from
3c72250 to
2ebf90e
Compare
risemeup1
force-pushed
the
set_permission
branch
from
0c1ff98 to
b3df359
Compare
tianshuo78520a
approved these changes
Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
others
PR changes
others
Describe
当改动了setup.py.in但是没有改动setup.py时，或者改动了setup.py没有同步改动setup.py.in时，需要approve