[Custom Extension] Fix custom double_grad backward=None #49224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
JiabinYang
reviewed
Dec 22, 2022
| @@ -153,7 +153,8 @@ def custom_relu_double_grad_dynamic(func, device, dtype, np_x, use_func=True): | |||
| dx = paddle.grad( | |||
| outputs=[out], inputs=[t], create_graph=True, retain_graph=True | |||
| ) | |||
|
|
|||
| if in_dygraph_mode(): | |||
There was a problem hiding this comment.
Maybe fix this test, since this test doesn't test double grad in the right way
There was a problem hiding this comment.
Already fix this, please review it again, thanks~
jiahy0825
added a commit
to jiahy0825/Paddle
that referenced
this pull request
Dec 23, 2022
…#49224) * fix custom double_grad backward=None * fix custom_relu.cu bug && polish testcase of double_grad * remove old dynamic graph test
phlrain
pushed a commit
that referenced
this pull request
Dec 27, 2022
* [Release2.4] Revert python link prs (#48573) * Revert "Fix mac link python (#48017)" This reverts commit 3fa7a73. * Revert "[Cherry-pick] Fix python link error (#47811)" This reverts commit ff642c6. * Update config.go * fix custom operator backward=None (#48656) * [Custom Extension] Fix custom double_grad backward=None (#49224) * fix custom double_grad backward=None * fix custom_relu.cu bug && polish testcase of double_grad * remove old dynamic graph test * add import fluid * add import fluid Co-authored-by: Chen Weihang <chenweihang@baidu.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
Others
Describe
Pre-PR fixes custom op bug of backward: [Custom operator] Fix custom operator backward=None bug #48656
This PR fixes custom op bug of double backward, follows the same idea of pre-PR.
Other change:
double_grad_dynamic, original test case cannot test eager mode.本 PR 修复了自定义算子二阶反向的 bug，遵循 [Custom operator] Fix custom operator backward=None bug #48656 相同的思路（前置 PR 修复了一阶反向的 bug）
其他改动：
double_grad_dynamic测试用例，原来的单测无法访问到新动态图下的二阶反向 op