Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ninja error while python>=3.9 #48867

Merged

Conversation

risemeup1
Copy link
Contributor

@risemeup1 risemeup1 commented Dec 7, 2022

PR types

others

PR changes

others

Describe

优化setup.py的逻辑
1 当用户export PY_VERSION=3.8,当前python环境不是3.8的时候,会进行提示,在一开始就报错,之前的逻辑会在编译的时候报错
image
2 当使用python大于等于3.9的时候,ninja编译会报错,原因是sconfig.get_config_var("INSTSONAME")获取python_libary和cmake里的find_packages()获取的python_libary不一致导致的

@paddle-bot
Copy link

paddle-bot bot commented Dec 7, 2022

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@risemeup1 risemeup1 force-pushed the fill_constant_batch_size_like_test branch from ac6be15 to fac56da Compare February 9, 2023 14:30
@risemeup1 risemeup1 changed the title Fill constant batch size like test Fix ninja error while python>=3.9 Feb 9, 2023
Copy link
Contributor

@zhangbo9674 zhangbo9674 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@risemeup1 risemeup1 merged commit 243cae5 into PaddlePaddle:develop Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants