Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make bfloat16 implicitly convert to float/double #48238

Merged
merged 3 commits into from
Nov 23, 2022

Conversation

sneaxiy
Copy link
Collaborator

@sneaxiy sneaxiy commented Nov 22, 2022

PR types

Function optimization

PR changes

Others

Describe

Make bfloat16 convert to float and double implicitly. This conversion is safe without any accuracy drop.

@paddle-bot
Copy link

paddle-bot bot commented Nov 22, 2022

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@sneaxiy sneaxiy changed the title Make bfloat16 implicit convert to float/double Make bfloat16 implicitly convert to float/double Nov 22, 2022
@sneaxiy sneaxiy requested a review from FeixLiu November 23, 2022 07:36
Copy link
Contributor

@FeixLiu FeixLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sneaxiy sneaxiy merged commit 1066094 into PaddlePaddle:develop Nov 23, 2022
@sneaxiy sneaxiy deleted the make_bfloat16_convert_implicit branch November 23, 2022 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants