optimize setup.py under conda virtual environment #48211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
risemeup1
force-pushed
the
add_eager_jit
branch
from
a26a578 to
941bf62
Compare
risemeup1
changed the title
zhangbo9674
reviewed
Feb 10, 2023
setup.py
Outdated
| @@ -1405,10 +1410,31 @@ def get_setup_parameters(): | |||
| ) | |||
|
|
|||
|
|
|||
| def check_build_dependency(): | |||
| python_dependcies_module = [ | |||
There was a problem hiding this comment.
这个列表直接从python/requirements.txt中获取吧
There was a problem hiding this comment.
尽量不要维护两处一模一样的内容，直接从requirements.txt中读取
| installed_packages = [r.decode().split('==')[0] for r in reqs.split()] | ||
| for dependency in python_dependcies_module: | ||
| if dependency not in installed_packages: | ||
| raise RuntimeError(missing_modules.format(dependency=dependency)) |
There was a problem hiding this comment.
可以，我优化一下，但是最后提示阶段，还是提示用户pip install -r python/requirements，而不是提示只安装缺失的包，因为python依赖库都有版本限制，pip install -r python/requirements可以确保依赖库版本都正确
setup.py
Outdated
| @@ -76,6 +76,11 @@ | |||
|
|
|||
| IS_WINDOWS = os.name == 'nt' | |||
|
|
|||
| missing_modules = ''' | |||
There was a problem hiding this comment.
不需要单独维护一个global string，直接写在函数中就好
zhangbo9674
reviewed
Feb 10, 2023
| f.read().splitlines() | ||
| ) # Specify the dependencies to install | ||
|
|
||
| python_dependcies_module = [] |
There was a problem hiding this comment.
利用正则会更简单一些，例如：re.sub("_|-", '', re.sub(r"==.|>=.|<=.*", '', "abc_d-e<=1.1")) 返回 abcde
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
others
PR changes
others
Describe
优化setup.py
当我们通过conda 创建一个新的空的环境时候，setup.py不会检查依赖，直接编译，会在cmake阶段报错缺少依赖，现在在cmake之前进行判断，并提示用户安装依赖，如缺少protobuf，则会提示，如图