Unify ProcessGroupNCCL APIs underlying implementation
#48163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
HermitSun
changed the title
HermitSun
changed the title
ProcessGroupNCCL APIs underlying implementation
LiYuRio
reviewed
Nov 19, 2022
| phi::DenseTensor* tensor, | ||
| int rank, | ||
| std::shared_ptr<ProcessGroup::Task> ProcessGroupNCCL::NCCLEnv( | ||
| const phi::DenseTensor& tensor, |
There was a problem hiding this comment.
如果想要这个语义的话，不建议传入一个tensor，还不如place和holder
There was a problem hiding this comment.
当时是考虑到万一后面还有别的参数，tensor 里包含的信息比较多
HermitSun
force-pushed
the
collective-p2p
branch
from
002cb2a to
73bda53
Compare
sljlp
approved these changes
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
APIs
Describe
由于集合通信
ProcessGroupNCCL底层接口的实现高度重合，在此统一接口实现，并规范接口参数，为动静统一时静态图传入的 const input 提供支持。