correct sync behavior for XPU distributed training #47882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
XPU support event mechanism similar to cuda event, so it is advisable to use an event to sync compute/comm streams for performance. However this mechanism is never fully tested, and inconsistent loss/ending_epochs are reported. Therefore, this PR replaces event sync with stream waiting as a temporary solution.
QingshuChen
reviewed
Nov 18, 2022
| @@ -64,7 +64,7 @@ struct XPUContext::Impl { | |||
| // manually destroy XPUStream here until xpu::api integrates this work | |||
| // into Context dtor | |||
| xpu_wait(context_->xpu_stream); | |||
| PADDLE_ENFORCE_XPU_SUCCESS(xpu_stream_destroy(context_->xpu_stream)); | |||
| xpu_stream_destroy(context_->xpu_stream); | |||
There was a problem hiding this comment.
编译器会complain在析构函数里抛异常，（这里其实有个try catch所以运行时倒不会出现程序异常终止，但还是可能会导致内存泄露）
最佳方法还是直接不去判断，如果xpu_stream_destroy出错可以依赖runtime的log
QingshuChen
approved these changes
Nov 18, 2022
|
你的PR已合入Paddle库，请关注后续测试结果。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
XPU support event mechanism similar to cuda event, so it is advisable to use an event to sync compute/comm streams for performance. However this mechanism is never fully tested, and inconsistent loss/ending_epochs are reported. Therefore, this PR replaces event sync with stream waiting as a temporary solution.