Remove place for process group #47857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
LiYuRio
force-pushed
the
dev_remove_place
branch
10 times, most recently
from
7992cda to
87138bf
Compare
HermitSun
reviewed
Nov 11, 2022
python/paddle/fluid/tests/unittests/collective/process_group_gloo.py
Outdated
Show resolved
Hide resolved
LiYuRio
force-pushed
the
dev_remove_place
branch
4 times, most recently
from
448ecbb to
44debce
Compare
LiYuRio
force-pushed
the
dev_remove_place
branch
from
44debce to
ffa75a4
Compare
LiYuRio
force-pushed
the
dev_remove_place
branch
from
ffa75a4 to
935299e
Compare
HermitSun
approved these changes
Nov 14, 2022
sljlp
approved these changes
Nov 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
ProcessGroup不应该和place绑定，而应该由调用通信操作的输入决定，之前引入place目测是为了解决套件在运行分布式时，卡1上调用place为卡0的操作，经过验证，目前这个错误已在动态图调用时被修复，同时在 #47740 中，保证调用通信操作时也会重新指定place，避免出现place错位的情况。