Add a new operator mp_allreduce_sum #47715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
LiYuRio
force-pushed
the
dev_allreduce_sum
branch
3 times, most recently
from
13b6ae1 to
f56860f
Compare
LiYuRio
force-pushed
the
dev_allreduce_sum
branch
from
f56860f to
69771e1
Compare
chenwhql
approved these changes
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
OPs
Describe
通信操作本身不应该有反向操作，但在目前的算子体系中，c_allreduce_sum接收use_mp作为它的一个属性，用于在mp场景下，将c_allreduce_sum的后向变成c_identity。为了修改这个语义，新增一个mp_allreduce_sum的操作，专用于mp场景下，并让c_allreduce_sum退化成一个普通的通信op，在下一个pr会清理c_allreduce_sum的use_mp的属性。