[PHI]Standardise some C++ API (Part2) #47510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
jiahy0825
approved these changes
Nov 1, 2022
zyfncg
approved these changes
Nov 1, 2022
| @@ -1163,7 +1163,7 @@ def triu(x, diagonal=0, name=None): | |||
|
|
|||
| """ | |||
| if in_dygraph_mode(): | |||
| return _C_ops.tril_triu(x, diagonal, False) | |||
| return _C_ops.tril(x, diagonal, False) | |||
There was a problem hiding this comment.
tril一个算子提供给tril和triu两个接口用，在命名上看有没有办法再规范一下
There was a problem hiding this comment.
后续对齐api的pr会处理一下这个问题
chenwhql
approved these changes
Nov 1, 2022
已提交修改pr，后续每个对齐api的PR都会同步提交customDevice修改 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
标准化如下C++ API接口，使其与Python API对齐：
hierarchical_sigmoid
reduce_prod
tril_triu
uniform_random
where_index
yolov3_loss
uniform_random_inplace
后续还会继续对接口标准化，此PR是系列工作的第二个PR