[PHI]Standardise some C++ API #47385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
zyfncg
reviewed
Oct 28, 2022
| @@ -2056,7 +2056,7 @@ | |||
| backward : psroi_pool_grad | |||
|
|
|||
| - op : put_along_axis | |||
| args : (Tensor arr, Tensor index, Tensor value, int axis, str reduce) | |||
| args : (Tensor arr, Tensor indices, Tensor values, int axis, str reduce) | |||
There was a problem hiding this comment.
done,3q very much
paddle/phi/api/yaml/ops.yaml
Outdated
| @@ -145,15 +145,15 @@ | |||
| func : fft_r2c | |||
| backward : fft_r2c_grad | |||
|
|
|||
| - op : graph_send_uv | |||
| - op : send_uv | |||
There was a problem hiding this comment.
这里生成的静态图 op 名也会从 graph_send_uv 变为了 send_uv, 得考虑是否有不兼容的问题
There was a problem hiding this comment.
done , 3q your revew
paddle/phi/infermeta/multiary.h
Outdated
Comment on lines
509
to
524
| void SendUERecvInferMeta(const MetaTensor& x, | ||
| const MetaTensor& y, | ||
| const MetaTensor& src_index, | ||
| const MetaTensor& dst_index, | ||
| const std::string& message_op, | ||
| const std::string& reduce_op, | ||
| const IntArray& out_size, | ||
| MetaTensor* out, | ||
| MetaTensor* dst_count); | ||
|
|
||
| void SendUVInferMeta(const MetaTensor& x, | ||
| const MetaTensor& y, | ||
| const MetaTensor& src_index, | ||
| const MetaTensor& dst_index, | ||
| const std::string& message_op, | ||
| MetaTensor* out); |
| const IntArray& out_size, | ||
| MetaTensor* out, | ||
| MetaTensor* dst_count); | ||
| void SendURecvInferMeta(const MetaTensor& x, |
zyfncg
approved these changes
Oct 31, 2022
| const IntArray& out_size, | ||
| MetaTensor* out, | ||
| MetaTensor* dst_count) { | ||
| void SendURecvInferMeta(const MetaTensor& x, |
chenwhql
approved these changes
Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
标准化如下C++ API接口，使其与Python API对齐：
addmm
put_along_axis
graph_send_uv
brelu
crop_tensor
gaussian_random
graph_send_recv
graph_send_ue_recv
后续还会继续对接口标准化，此PR是系列工作的第一个PR