-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CodeStyle][py2] remove paddle.compat
#47269
[CodeStyle][py2] remove paddle.compat
#47269
Conversation
你的PR提交成功,感谢你对开源项目的贡献! |
paddle.compat
paddle.compat
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR-CI-Coverage 和 PR-CI-Mac-Python3 由于移除单测 test_compat
挂掉了,已经按照说明在 https://github.com/PaddlePaddle/Paddle/wiki/Temporarily-disabled-Unit-Test 说明了理由
@@ -6955,7 +6955,7 @@ def mlp(input_x, input_y, hid_dim=128, label_dim=2): | |||
state_dict = {} | |||
sgd.load(state_dict) | |||
except NotImplementedError as e: | |||
print(cpt.get_exception_message(e)) | |||
print(e) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
一处 API 文档变动:移除了一个示例代码的 compat
模块的使用,为通过示例代码运行添加了 enable_static
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🎆 🎆 🎆 https://github.com/PaddlePaddle/docs/tree/develop/docs/api/paddle/compat 这个目录也可以删除了。 |
嗯嗯,之后我在 docs 那边一起清理下(API 文档 + 其余文档中的相关使用等等)~ UPDATE: |
PR types
Others
PR changes
Others
Describe
清理
compat
模块的最后一步,彻底清理掉 paddle.compat 模块、单测以及一些 unused importsRelated links
compat
part1: [CodeStyle] remove compat module (long_type, int_type, get_exception_message, floor_division) #46686compat
part2: [CodeStyle][py2] remove compat module (round) #46923compat
part3: [CodeStyle][py2] removecompat
module (to_bytes) #47035compat
part4: [CodeStyle][py2] removecompat
module (to_text) #47036