[CodeStyle] add more information when codestyle check failed #47116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
SigureMo
commented
Oct 18, 2022
| echo "Then, run pre-commit to check codestyle issues in your PR:" | ||
| echo "" | ||
| echo " pre-commit run --files" $(echo ${diff_files[*]} | tr "\n" " ") | ||
| echo "" |
There was a problem hiding this comment.
仅仅提示安装命令只能保证新的 commit 可以通过，而不能保证 PR 里之前的 commit 通过，因此这里命令用于提示如何复现这个 PR 里的全部问题
这里提示的命令与 37 行一致，以保证本地可以复现/自动修复 CI 上的相关问题
为避免一些较大的 PR（如一些全量替换）时这里命令长度过长导致难以注意到有效的信息，仅仅会在修改文件数量小于等于 100 时提示本信息
There was a problem hiding this comment.
其余两个文件目前只是用于触发 pre-commit 测试效果，如果没有问题就可以直接恢复了
SigureMo
changed the title
已恢复～ |
luotao1
approved these changes
Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
详情见 #46808 (comment)
为 codestyle check 失败时添加更多的提示信息，包括：
除去
tools/codestyle/pre_commit.sh的改动都是用来测试的，将会在之后恢复