Restructure device context #4593
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
October 3, 2017 17:10
QiJune
reviewed
Oct 4, 2017
cmake/configure.cmake
Outdated
| add_definitions(-DPADDLE_ONLY_CPU) | ||
| add_definitions(-DHPPL_STUB_FUNC) | ||
|
|
||
| list(APPEND CMAKE_CXX_SOURCE_FILE_EXTENSIONS cu) | ||
| else() | ||
| add_definitions(-DPADDLE_WITH_CUDA) |
There was a problem hiding this comment.
We now have -DPADDLE_WITH_GPU already, please merge the latest develop branch first.
|
|
||
| virtual void Wait() const {} | ||
| }; | ||
|
|
||
| class CPUDeviceContext : public DeviceContext { |
There was a problem hiding this comment.
Since we use boost::variant instead of instead of inheritance, we should remove derivation.
|
Since you haven't replied for a long time, we have closed this issue/pr. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4581